fix: remove delve from public images#22389
Merged
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
product-security-plaid-production
Bot
requested review from
chainchad,
gustavogama-cll and
justinkaseman
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR adjusts the Chainlink Docker build to keep delve (dlv) out of publicly published images by splitting the Dockerfiles into separate final (release) and debug targets, and updating CI workflows to build the appropriate target per pipeline.
Changes:
- Split both
core/chainlink.Dockerfileandplugins/chainlink.Dockerfileintofinalanddebugstages, copyingdlvonly intodebug. - Update
.github/workflows/docker-build.ymlto build thedebugtarget. - Update
.github/workflows/build-publish.ymlto build thefinaltarget for publish.
Scrupulous human review recommended:
- Docker stage ordering/target selection: ensure no production/public pipeline (including any external/manual build paths) can accidentally build/publish the
debugstage. - Reusable workflow input compatibility: confirm
docker-targetis a supported input across the specific reusable workflow refs being used.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/chainlink.Dockerfile | Introduces final and debug targets; dlv is only copied into debug. |
| core/chainlink.Dockerfile | Same final/debug split for the core image; dlv only in debug. |
| .github/workflows/docker-build.yml | Sets Docker builds to target debug in the build workflow. |
| .github/workflows/build-publish.yml | Sets Docker builds to target final for publish workflow. |
gustavogama-cll
approved these changes
May 12, 2026
kalverra
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unneeded dep for our publicly released images.
Changes
final,debug)delveis only copied to the image whendebugis target is chosenbuild-publishpipeline to targetfinal, whereasdocker-buildpipeline targetsdebugTesting
Builds (debug) are successful: https://github.com/smartcontractkit/chainlink/actions/runs/25699227711?pr=22389
Notes
Sonarqube is complaining with:
This is not true as it inherits from
final. Leaving as is.DX-4135